Skip to content

Avoid double free in Free_Ctrl(). C.savecpt points to same memory as C.file #8951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joa-quim merged 1 commit into from
Mar 24, 2026
+10 −11
Merged

Avoid double free in Free_Ctrl(). C.savecpt points to same memory as C.file #8951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions src/grdimage.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,18 +159,17 @@ static void *New_Ctrl (struct GMT_CTRL *GMT) { /* Allocate and initialize a new
return (C);
}

static void Free_Ctrl (struct GMT_CTRL *GMT, struct GRDIMAGE_CTRL *C) { /* Deallocate control structure */
static void Free_Ctrl(struct GMT_CTRL *GMT, struct GRDIMAGE_CTRL *C) { /* Deallocate control structure */
if (!C) return;
gmt_M_str_free (C->In.file);
gmt_M_str_free (C->A.file);
gmt_M_str_free (C->C.file);
gmt_M_str_free (C->C.savecpt);
gmt_M_str_free (C->I.file);
gmt_M_str_free (C->I.azimuth);
gmt_M_str_free (C->I.ambient);
gmt_M_str_free (C->I.method);
gmt_M_str_free (C->Out.file);
gmt_M_free (GMT, C);
gmt_M_str_free(C->In.file);
gmt_M_str_free(C->A.file);
gmt_M_str_free(C->C.file);
gmt_M_str_free(C->I.file);
gmt_M_str_free(C->I.azimuth);
gmt_M_str_free(C->I.ambient);
gmt_M_str_free(C->I.method);
gmt_M_str_free(C->Out.file);
gmt_M_free(GMT, C);
}

static int usage (struct GMTAPI_CTRL *API, int level) {
Expand Down
Loading