Conversation
joa-quim
approved these changes
Jul 3, 2026
joa-quim
left a comment
Member
There was a problem hiding this comment.
I'll be very extra cautious in using other models than Anthropic's (even Sonnet, though Sonnet 5 is a good surprise but previous one was moderately bad). GLM, for example, is ver acclaimed but my experience with it was bad. Have no experience with OpenAI top models though.
This fix seams simple so it should not harm.
Member
Author
|
I agree. I will ask Sonnet to review the patch before merging, just to get an additional set of eyes on it. |
Member
Author
|
Based on Claude's suggestion:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted by Qwen 3.7 Plus
Bug:
psevents applies the -q filter, and writes the selected data to temporary files. Afterwards, it calls internal modules to plot the symbols/labels from these temporary files. Because the -q option remained active, the internal modules applied the exact same filter a second time on the already-filtered temporary files.
Solution:
Implemented a local patch to temporarily suspend the -q option before calling the internal modules, and restore it immediately after.
Alternative solution:
I also considered modifying the global
gmt_disable_bghio_opts()andgmt_reenable_bghio_opts()functions ingmt_io.cto include-q. However, this will affect dozens of other modules, and I'm not sure if the -q option should also be disabled for them. But maybe it should.Test with:
I use -
qi0:30:to plot a data point every 30.Closes #8460.