Skip to content

Earth wdmam 2.2#270

Merged
Esteban82 merged 4 commits intomasterfrom
earth_wdmam_2.2
Apr 15, 2025
Merged

Earth wdmam 2.2#270
Esteban82 merged 4 commits intomasterfrom
earth_wdmam_2.2

Conversation

@Esteban82
Copy link
Copy Markdown
Member

Update recipe for earth wdmam 2.2. See #245

@Esteban82 Esteban82 requested review from a team, joa-quim and seisman March 19, 2025 13:15
@Esteban82 Esteban82 self-assigned this Mar 19, 2025
@Esteban82
Copy link
Copy Markdown
Member Author

In the recipe it says:
# SRC_FILE=ftp://ftp.soest.hawaii.edu/pwessel/WDMAM/grid.asc.txt
Where should I put the original txt file? I think I can't use the original source (https://wdmam.org/) because it is necessary to log in to download the data. This is the same issue discused on #268. I think we can use the same server. My question is where exactly should I put it? In /export/gmtserver/pwessel ?

@joa-quim
Copy link
Copy Markdown
Member

I find the data in the gmtserver too messy for me to understand it. IMO, we should remove all old-earth-relief*_ directories and the files in candidate be removed after they are upgraded from candidate to final. The WDMAM file should be only stored as a .nc grid and no grid.asc.txt, if I understand it well it's a ascii version of the grid, and stored under /export/gmtserver/gmt/data/server/earth/earth_wdmam

@Esteban82
Copy link
Copy Markdown
Member Author

I find the data in the gmtserver too messy for me to understand it. IMO, we should remove all old-earth-relief*_ directories

Yes, I agree that we should delete those 3 directories.

and the files in candidate be removed after they are upgraded from candidate to final.

Yes, I agree. Paul wrote this in the makefile. So I think we should do it.

# Completely wipe the candidate/server directory on the candidate server
candidate-delete:
		ssh candidate.generic-mapping-tools.org "rm -rf /export/gmtserver/gmt/candidate/server; mkdir /export/gmtserver/gmt/candidate/server"

The WDMAM file should be only stored as a .nc grid and no grid.asc.txt, if I understand it well it's a ascii version of the grid

Sounds good. But if the nc is stored, then I think the followings lines (in the recipe) should be edited/deleted. I could try to do it.

# Since source is an ASCII grid we supply conversion command and original extension
# SRC_CUSTOM="gmt xyz2grd grid.asc.txt -i0,1,2 -Rd -I3m -fg -Ggrid.asc.nc"
# SRC_EXT=txt

and stored under /export/gmtserver/gmt/data/server/earth/earth_wdmam

I think if we put it there, then it will be copied by the other mirrors. I think it would be better to put it in a directory outside of gmt/data/. Maybe something like /export/gmtserver/gmt/backup_data/, /export/gmtserver/gmt/original_data/ or /export/gmtserver/gmt/source_data/.

@joa-quim
Copy link
Copy Markdown
Member

I think if we put it there, then it will be copied by the other mirrors.

Yes, that's the whole idea. I don't see why we should be keeping a copy of the original ascii data. Just store the nc version and get rid of the temporaries.

@seisman
Copy link
Copy Markdown
Member

seisman commented Mar 19, 2025

Sounds good. But if the nc is stored, then I think the followings lines (in the recipe) should be edited/deleted. I could try to do it.

# Since source is an ASCII grid we supply conversion command and original extension
# SRC_CUSTOM="gmt xyz2grd grid.asc.txt -i0,1,2 -Rd -I3m -fg -Ggrid.asc.nc"
# SRC_EXT=txt

I don't think the SRC_CUSTOM line should be edited. It's the command to convert the original ascii file to the nc grid we need. If you remove it, next time, we may have no idea how to do the ascii->nc conversion.

@Esteban82
Copy link
Copy Markdown
Member Author

I don't think the SRC_CUSTOM line should be edited. It's the command to convert the original ascii file to the nc grid we need. If you remove it, next time, we may have no idea how to do the ascii->nc conversion.

Yes, thanks. It is important to save this info.

@Esteban82
Copy link
Copy Markdown
Member Author

Update the recipe. Just so you can see it. It's not meant to be defining.

With the current version, you can make earth-wdmam and it works fine.

First, I did what I put in the comments:

# Data must first be downloaded from https://wdmam.org/ manually.
# Then converted to grid file with "gmt xyz2grd grid.txt -i0,1,2 -Rd -I3m -fg -Gearth_wdmam_2.2.nc",
# and finally place it this directory on the candidate server https://candidate.generic-mapping-tools.org/

I don't like having to put the file on the candidate server. It is confusing and may be deleted. I created the directory /export/gmtserver/gmt/source_data but I don't know what is the URL to access that folder. Do you know how to do it?

@Esteban82
Copy link
Copy Markdown
Member Author

Yes, that's the whole idea. I don't see why we should be keeping a copy of the original ascii data. Just store the nc version and get rid of the temporaries.

I don't know if I understood correctly. I have the impression that you are confusing the grid.nc file (that I now call earth_wdmam_2.2.nc and that is in the candidate server) with the files that are downloaded by the users when they do @earth-wdmam. The earth_wdmam_2.2.nc file is processed to create the other files. That's why I don't see sense that the earth_wdmam_2.2.nc file is copied by the mirrors.

Copy link
Copy Markdown
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Esteban82 Esteban82 merged commit 864b71e into master Apr 15, 2025
1 check passed
@Esteban82 Esteban82 deleted the earth_wdmam_2.2 branch April 15, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants