Skip to content

Remove xfails on solar and velo tests for GMT 6.2.0rc2 #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2021
Merged

Remove xfails on solar and velo tests for GMT 6.2.0rc2 #1297

merged 2 commits into from
May 26, 2021

Conversation

@willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented May 26, 2021 •
edited
Loading

Per #1289, this removes the xfail decorators from 2 tests that are no longer needed.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels May 26, 2021
@willschlitzer willschlitzer added this to the 0.4.0 milestone May 26, 2021
@willschlitzer willschlitzer self-assigned this May 26, 2021
@willschlitzer willschlitzer mentioned this pull request May 26, 2021
Closed
13 tasks
weiji14
weiji14 approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@willschlitzer willschlitzer merged commit f747e71 into master May 26, 2021
@willschlitzer willschlitzer deleted the solar-xfail branch May 26, 2021 09:27
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@willschlitzer
Remove xfails on solar and velo tests for GMT 6.2.0rc2 (GenericMappin…
e29e50b 
…gTools#1297)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelgrund michaelgrund michaelgrund approved these changes

@weiji14 weiji14 weiji14 approved these changes

Assignees

@willschlitzer willschlitzer

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@willschlitzer @michaelgrund @weiji14