pygmt.grdfill: Remove the private function _validate_params#4413
Merged
pygmt.grdfill: Remove the private function _validate_params#4413
Conversation
seisman
added
maintenance
seisman
added
final review call
seisman
removed
the
final review call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The private function
_validate_paramswas introduced in PR #3880 to check for conflicting parameters, specifically the deprecatedmodeparameter alongside the newly addedconstantfill,gridfill,neighborfill,splinefill, andinquireoptions. This function was intended to simplify the main function's logic.Now that the deprecated
modeparameter has been removed, the validation logic in_validate_paramshas become minimal. The function can be merged into the main function without adding significant complexity, making the code more straightforward.