Ship test/shipyard-ship-cycle-2 - #115
Merged
danielraffel merged 5 commits intoApr 11, 2026
Merged
Conversation
A prior smoke run cached PULP_BUILD_TESTS=OFF in CMakeCache.txt. CMake reuses cached values when not explicitly passed, so the default validation silently skipped test targets — ctest reported "No tests were found!!!" with rc=0. Adding explicit -D flags ensures tests are always built regardless of prior cache state.
CMAKE_SYSTEM_PROCESSOR reports the HOST arch (ARM64) not the TARGET arch on Windows. When cross-compiling with -A x64 on an ARM64 host, this caused Pulp to download ARM64 wgpu binaries and try to link them into an x64 build — producing LNK2019 + LNK4272 errors on every wgpu symbol. Fix: use CMAKE_GENERATOR_PLATFORM (set by -A flag) when available, falling back to CMAKE_SYSTEM_PROCESSOR for non-VS generators. Also forces PULP_BUILD_TESTS=ON in the default Shipyard validation configure command to prevent smoke-run cache poisoning.
danielraffel
force-pushed
the
test/shipyard-ship-cycle-2
branch
from
April 11, 2026 12:51
c88103c to
3732086
Compare
Three root causes:
1. POSIX-only subprocess paths (3 tests):
- exec("echo", ...) — echo is a cmd.exe builtin, not a standalone exe
- run_process("/bin/echo", ...) — /bin/echo doesn't exist on Windows
- run_process("/bin/sh", ...) — /bin/sh doesn't exist on Windows
Fix: add #ifdef _WIN32 alternatives using cmd.exe /c.
2. Unicode em-dash in test names (5 tests):
- CTest on Windows passes test name filters via cmd.exe, which
mangles UTF-8 em-dash (U+2014) to garbled "G\x{c3}\x{a9}"
- Catch2 then can't match the filter → "No test cases matched"
→ reports "No tests ran" which CTest counts as failure
Fix: replace em-dash — with ASCII -- in test case names.
3. Toolbar SEGFAULT (1 test):
- Toolbar constructor likely crashes in headless Yoga layout on
Windows (null parent context)
- Already tagged [!mayfail] but SEGFAULT kills the executable
before Catch2 processes the tag
Fix: add to --exclude-regex in shipyard config alongside
AudioWorkgroup. Proper fix needs Windows debugging.
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by Shipyard