Fix some AMQP issues#393
Merged
mbabker merged 2 commits intoGeniusesOfSymfony:masterfrom Aug 27, 2019
alexismarquis:master
Merged
Fix some AMQP issues#393mbabker merged 2 commits intoGeniusesOfSymfony:masterfrom alexismarquis:master
mbabker merged 2 commits intoGeniusesOfSymfony:masterfrom
alexismarquis:master
Conversation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with the AMQP pusher I ran into when updating to latest version, both happening when trying to use the pusher.
The exchange was being created before establishing the connection
I changed the default routing key from
nullto an empty string since it seems that the\AMQPExchange::publishmethod signature has explicit type hints with php 7.