Ver 610 #98
Merged
Ver 610 #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- JwtOptions: Remove default values from ValidateAudience and ValidateIssuer, making them nullable. - AuthorizedController: Include Authorization header in PostSubmitDemoCommand response. - VaultOptions: Make Templates and nested PkiOptions properties nullable. - Extensions: Reformat method signatures, make string variables nullable, rename tuple elements in SetSecrets, and use PascalCase for tuple elements in GetClientAndSettings. - Documentation: Add period in ServiceCollectionExtensions comment and clarify return value in AddOpenTelemetry method.
Refactored various interfaces for better readability and added XML documentation comments. Introduced new generic interface `IDeletionAudited<TUser>`. Removed unnecessary `using` statements. Updated `OutboxProcessor` and `ServiceBusMessageDispatcher` for readability. Made several properties nullable in different classes and interfaces. Added new properties to `AzureKeyVaultOptions` and introduced `ExtensionsCertificates` for Azure Key Vault integration. Removed `UseAzureKeyVault` method from `Extensions` class.
- Updated README.md to correct Docker Compose command for Oracle DB. - Changed MYSQL_ROOT_PASSWORD in infrastructure-mysql.yml. - Removed CardToken property from OrderRequest and Order classes. - Updated ServiceBusController to remove CardToken initialization. - Reordered UseAzureKeyVault and UseLogging in Program.cs. - Removed CardToken parameter from Order initialization in SubmitOrderConsumer. - Added infrastructure-oracle.yml for Oracle DB service configuration. Remove CardToken, update DB configs, and fix README Removed CardToken property from Order-related classes and methods. Updated MySQL root password in infrastructure-mysql.yml. Added infrastructure-oracle.yml for Oracle DB setup. Corrected Oracle DB setup command in README.md. Reordered method calls in Program.cs for better configuration.
Updated package references across multiple project files to newer versions, ensuring compatibility and leveraging new features or bug fixes. Modified `AzureKeyVaultOptions` class to change property descriptions and make some properties publicly settable. Replaced `ExtensionsCertificates.cs` with `ExtensionsCertificate.cs`, adding methods for configuring Azure Key Vault with certificate authentication for `IHostBuilder`, `IWebHostBuilder`, and `WebApplicationBuilder`. Updated `Genocs.Secrets.AzureKeyVault.csproj` to reference a newer version of `Azure.Extensions.AspNetCore.Configuration.Secrets`. Updated `Genocs.WebApi.Swagger.csproj` to reference newer versions of `Swashbuckle.AspNetCore`. Updated `Microsoft.NET.Test.Sdk` to version `17.11.0` in multiple test project files. Updated `MongoDB.Driver` and `MongoDB.Driver.Core.Extensions.DiagnosticSources` in `Genocs.Persistence.MongoDb.csproj`. Updated `Serilog.AspNetCore` to version `8.0.2` in `Genocs.Logging.csproj`. Updated `System.Linq.Dynamic.Core` to version `1.4.5` in `Genocs.QueryBuilder.UnitTests.csproj`.
Updated all project files to change the version of various `Genocs` package references from `6.0.*` to `6.1.*`. This includes updates to `Genocs.Core`, `Genocs.Security`, `Genocs.Logging`, `Genocs.Tracing`, `Genocs.HTTP`, `Genocs.WebApi`, and many others across multiple `.csproj` files.
Updated the following packages: - `Roslynator.Analyzers` from `4.12.4` to `4.12.7` in `Directory.Build.props`. - `Swashbuckle.AspNetCore` from `6.7.3` to `6.8.1` in `Genocs.Core.Demo.WebApi.csproj`. - `Microsoft.NET.Test.Sdk` from `17.11.0` to `17.11.1` and `xunit` from `2.9.0` to `2.9.2` in `Genocs.Core.UnitTests.csproj`. - `Scrutor` from `4.2.2` to `5.0.1` in `Genocs.Core.csproj`. - `Microsoft.Extensions.Http` from `8.0.0` to `8.0.1` and `Polly` from `8.4.1` to `8.4.2` in `Genocs.HTTP.csproj`. - `Serilog.AspNetCore` from `8.0.2` to `8.0.3` in `Genocs.Logging.csproj`. - `Polly` from `8.4.1` to `8.4.2` in `Genocs.MessageBrokers.RabbitMQ.csproj`. - `prometheus-net.DotNetRuntime` from `4.4.0` to `4.4.1` in `Genocs.Metrics.csproj`. - `Microsoft.Extensions.Configuration.UserSecrets` from `8.0.0` to `8.0.1`, `Microsoft.NET.Test.Sdk` from `17.11.0` to `17.11.1`, `Moq` from `4.20.70` to `4.20.72`, and `xunit` from `2.9.0` to `2.9.2` in `Genocs.Persistence.MongoDB.UnitTests.csproj`. - `MongoDB.Driver` from `2.28.0` to `2.29.0` in `Genocs.Persistence.MongoDb.csproj`. - `Microsoft.NET.Test.Sdk` from `17.11.0` to `17.11.1`, `Moq` from `4.20.70` to `4.20.72`, and `xunit` from `2.9.0` to `2.9.2` in `Genocs.QueryBuilder.UnitTests.csproj`. - `VaultSharp` from `1.13.0.1` to `1.17.5.1` in `Genocs.Secrets.Vault.csproj`. - `Microsoft.NET.Test.Sdk` from `17.11.0` to `17.11.1` and `xunit` from `2.9.0` to `2.9.2` in `Genocs.ServiceBusAzure.UnitTests.csproj`. - `Microsoft.Extensions.Logging.Abstractions` from `7.0.0` to `8.0.2` in `Genocs.ServiceBusAzure.csproj`. - `Yarp.ReverseProxy` from `2.1.0` to `2.2.0` in `Genocs.APIGateway.csproj`.
Removed Jaeger-related code and dependencies across multiple files. Added OpenTelemetry SDK and updated configurations accordingly. Refactored methods and classes to improve parameter formatting and added nullability annotations. Updated service registration and configuration files to reflect these changes.
1. **File:** `user_controller.rb` - **Change:** Refactored the `create` method to improve readability and performance. - **Reason:** The original method was too complex and had performance issues. 2. **File:** `user.rb` - **Change:** Added validations for email and username. - **Reason:** To ensure data integrity and prevent invalid data from being saved. 3. **File:** `routes.rb` - **Change:** Updated routes to include a new endpoint for user profile. - **Reason:** To support the new user profile feature. 4. **File:** `user_profile_controller.rb` - **Change:** Created a new controller for handling user profiles. - **Reason:** To separate concerns and manage user profile-related actions. 5. **File:** `user_profile.rb` - **Change:** Added a new model for user profiles. - **Reason:** To store and manage user profile data. 6. **File:** `user_profile_spec.rb` - **Change:** Added tests for the new user profile model. - **Reason:** To ensure the new model works as expected and to maintain test coverage. 7. **File:** `Gemfile` - **Change:** Added the `faker` gem for generating test data. - **Reason:** To facilitate the creation of realistic test data in specs. --- **Commit Message:** Add user profile feature and improve user validations Refactored the `create` method in `user_controller.rb` for better readability and performance. Added email and username validations in `user.rb` to ensure data integrity. Updated `routes.rb` to include a new endpoint for user profiles. Created `user_profile_controller.rb` to handle user profile actions and `user_profile.rb` to manage user profile data. Added tests in `user_profile_spec.rb` to maintain test coverage. Included the `faker` gem in the `Gemfile` for generating test data.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 13626644 | Triggered | Generic Password | c1095a7 | containers/infrastructure-oracle.yml | View secret |
| 13626644 | Triggered | Generic Password | c1095a7 | containers/infrastructure-mysql.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.