feat: stub vlm request endpoint (#17)#22
Merged
Conversation
jennifer-bowser
commented
Dec 4, 2025
jennifer-bowser
commented
Dec 4, 2025
quinnwai
previously approved these changes
Dec 4, 2025
Contributor
quinnwai
left a comment
quinnwai
left a comment
There was a problem hiding this comment.
lgtm! Minor comments if you'd like them
korikuzma
reviewed
Dec 8, 2025
jsstevenson
reviewed
Dec 11, 2025
Member
There was a problem hiding this comment.
Consider moving some of this stuff to /schemas/vlm.py, since it's being used to validate inputs coming in on the VLM protocol.
korikuzma
requested changes
Dec 11, 2025
Member
korikuzma
left a comment
korikuzma
left a comment
There was a problem hiding this comment.
Agree with suggestions from @jsstevenson as well
Co-authored-by: James Stevenson <james.stevenson@nationwidechildrens.org>
Co-authored-by: James Stevenson <james.stevenson@nationwidechildrens.org>
…y the auto-generated documentation
Co-authored-by: Kori Kuzma <korikuzma@gmail.com>
jennifer-bowser
dismissed stale reviews from korikuzma and quinnwai
via
8ac5e44
korikuzma
approved these changes
Dec 15, 2025
Member
korikuzma
left a comment
korikuzma
left a comment
There was a problem hiding this comment.
Could also use pytest.mark.parameterize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #17