Skip to content

Conversation

@jarbesfeld
Copy link
Contributor

closes #443

I investigated this function further and it seems the issue may have been that more clarification was needed for this part of the function docstrings:

:param pos: (start pos, end pos).

Since UTA uses inter-residue coordinates, I interpreted this as describing the inter-residue coordinates for a part of sequence that is being examined. I updated the docstrings to describe this, and modified the tests so that both positive and negative transcripts are being examined.

@jarbesfeld jarbesfeld self-assigned this Dec 3, 2025
@jarbesfeld jarbesfeld requested a review from a team as a code owner December 3, 2025 22:33
@jarbesfeld jarbesfeld added enhancement New feature or request priority:low Low priority labels Dec 3, 2025
@jarbesfeld
Copy link
Contributor Author

@korikuzma It looks like coordinates are converted to inter-residue before running this method, as seen in this example from the alignment.py module.

@jarbesfeld
Copy link
Contributor Author

The other place where this method is run is in the mane_transcript.py module. It is called in _get_and_validate_genomic_tx_data function.

It looks like the position coordinates are converted to inter-residue coordinate by using the get_inter_residue_pos function from the utils.py module.

@korikuzma
Copy link
Member

The other place where this method is run is in the mane_transcript.py module. It is called in _get_and_validate_genomic_tx_data function.

It looks like the position coordinates are converted to inter-residue coordinate by using the get_inter_residue_pos function from the utils.py module.

Should update the docstring to reflect this

Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarbesfeld jarbesfeld requested a review from korikuzma December 8, 2025 14:18
@jarbesfeld
Copy link
Contributor Author

@korikuzma When I re-ran the tests I saw some were failing because some of the Ensembl gene versions were out of date. It looks like there may have been a update over the weekend, so I incremented the gene accession versions and now the tests pass

Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we might want to scope the fix in the PR title: fix(docs)

@jarbesfeld jarbesfeld changed the title fix: Update get_genomic_tx_data function fix(docs): Update get_genomic_tx_data function Dec 8, 2025
@jarbesfeld jarbesfeld merged commit 32c6f9b into main Dec 8, 2025
18 checks passed
@jarbesfeld jarbesfeld deleted the issue-443 branch December 8, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority:low Low priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate get_genomic_tx_data function

3 participants