feat!: make all namedtuples typed, and remove unnormalized option #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcannon068nw
approved these changes
Dec 31, 2024
mcannon068nw
left a comment
mcannon068nw
left a comment
There was a problem hiding this comment.
approved, but just forget how some of the test suite is set up
| results = get_nda_results("207145", True) | ||
| results = get_nda_results("207145") | ||
| assert results | ||
| assert len(results) > 0 |
There was a problem hiding this comment.
what were these True values for in the test?
Member
Author
There was a problem hiding this comment.
Oh yeah I forgot I did this. Updated the description
jsstevenson
changed the title
|
This PR is stale because it has been open 7 day(s) with no activity. Please review this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.