Skip to content

feat: add FASTA sequence download#106

Merged
jsstevenson merged 7 commits intostagingfrom
issue-102
Oct 11, 2022
Merged

feat: add FASTA sequence download#106
jsstevenson merged 7 commits intostagingfrom
issue-102

Conversation

@jsstevenson
Copy link
Member

@jsstevenson jsstevenson commented Oct 10, 2022

close #102

@jsstevenson jsstevenson requested a review from korikuzma October 10, 2022 12:17
@jsstevenson jsstevenson marked this pull request as ready for review October 10, 2022 12:17
korikuzma
korikuzma previously approved these changes Oct 10, 2022
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jsstevenson jsstevenson requested a review from korikuzma October 10, 2022 19:56
korikuzma
korikuzma previously approved these changes Oct 11, 2022
aliases = self._get_fasta_aliases(sequence_id, ["refseq", "ga4gh"])
header = f">emb|ensembl:{sequence_id}|{'|'.join(aliases)}"
else:
aliases = self._get_fasta_aliases(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we wanted to add a test for this, we could use the seguid

jsstevenson and others added 3 commits October 11, 2022 08:27
Co-authored-by: Kori Kuzma <42851808+korikuzma@users.noreply.github.com>
@jsstevenson
Copy link
Member Author

alright! maybe finally done?

@jsstevenson jsstevenson requested a review from korikuzma October 11, 2022 13:09
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jsstevenson jsstevenson merged commit a59c823 into staging Oct 11, 2022
@jsstevenson jsstevenson deleted the issue-102 branch October 11, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants