fix(sync): validate autosync accepted seqs#375
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens autosync’s safety checks when pushing local mutations to Engram Cloud by requiring the server to return an accepted_seqs list whose cardinality matches the pushed batch before acknowledging (acking) local mutation seqs. This prevents autosync from marking local mutations as acked when the server response is missing or structurally inconsistent, addressing reported silent-ack failure modes.
Changes:
- Validate that
PushMutationsreturns a non-nil result and thataccepted_seqscount matches the pushed batch size before acking local mutation seqs. - Ensure autosync continues to ack the original local mutation
Seqvalues (not cloud-assigned seq values). - Add regression tests covering nil/empty/short/long
accepted_seqsresponses.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/cloud/autosync/manager.go |
Adds result validation and accepted_seqs cardinality checks before acking local mutation seqs. |
internal/cloud/autosync/manager_test.go |
Adds/updates tests to ensure local seqs are acked only when accepted_seqs cardinality matches, and never acked on mismatch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accepted_seqscardinality before autosync acks local mutationsFixes #238
Fixes #298
Tests
go test ./internal/cloud/autosync ./cmd/engramgo test ./...Review