fix(cloud): send Authorization header on sync --cloud using file token fallback#430
Merged
Merged
Conversation
…unset resolveCloudRuntimeConfig was zeroing cc.Token unconditionally before reading the env var, so any token persisted in cloud.json was silently discarded. Users running `engram sync --cloud` without ENGRAM_CLOUD_TOKEN exported always received a 401 even when cloud.json held a valid token. Remove the blanket zero assignment so the file token acts as a fallback when the env var is absent. ENGRAM_CLOUD_TOKEN still takes precedence when set. Update the test that locked in the old behaviour and add three new tests that assert the fallback and the end-to-end Authorization header. Closes #343
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveCloudRuntimeConfigincmd/engram/main.gozeroedcc.Tokenbefore readingENGRAM_CLOUD_TOKEN, so any token persisted incloud.jsonwas silently discarded on every call.engram sync --cloudin a fresh shell withoutENGRAM_CLOUD_TOKENexported always got 401, even with a valid token incloud.json(noAuthorizationheader was sent).cc.Token = "". The file token is now a fallback; the env var still takes precedence when set.Test plan
TestResolveCloudRuntimeConfigFallsBackToFileToken— file token used when env absentTestResolveCloudRuntimeConfigEnvTokenTakesPrecedence— env overrides file tokenTestSyncCloudSendsAuthorizationHeaderFromFileToken— e2e via httptest:Authorization: Bearer <token>present on the actual requestgo test ./... && go vet ./... && go build ./...cleanCloses #343