Skip to content

feat: update golangci-lint action, and binary version#353

Merged
wilsonjord merged 1 commit intomainfrom
feat-golang-lint-update
Mar 17, 2026
Merged

feat: update golangci-lint action, and binary version#353
wilsonjord merged 1 commit intomainfrom
feat-golang-lint-update

Conversation

@wilsonjord
Copy link
Contributor

This PR uses the recently synced GeoNet/golangci-lint-action, and the latest version as at now of the golangci-lint binary.
This is to support go1.25 applications. Tested here: https://github.com/GeoNet/nema-mar-portal/actions
Previous error:

Running [/home/runner/golangci-lint-1.64.2-linux-amd64/golangci-lint run  --timeout 30m -E gosec] in [/home/runner/work/nema-mar-portal/nema-mar-portal] ...
  Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25)
  Failed executing command with error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25)
  
  Error: golangci-lint exit with code 3
  Ran golangci-lint in 141ms

This PR enables the linting to run appropriately now:

  Running [/home/runner/golangci-lint-2.11.3-linux-amd64/golangci-lint config path] in [/home/runner/work/nema-mar-portal/nema-mar-portal] ...
  Running [/home/runner/golangci-lint-2.11.3-linux-amd64/golangci-lint run  --timeout 30m -E gosec] in [/home/runner/work/nema-mar-portal/nema-mar-portal] ...
  Error: internal/ui/ui.go:5:12: pattern dist: no matching files found (typecheck)
  //go:embed dist
             ^
  1 issues:
  * typecheck: 1
  
  Error: issues found
  Ran golangci-lint in 27981ms

Bump golangci-lint action, and update version of binary used to perform
linting.
@wilsonjord wilsonjord force-pushed the feat-golang-lint-update branch from 2d36f98 to 538122f Compare March 17, 2026 03:14
@wilsonjord wilsonjord requested a review from junghao March 17, 2026 03:18
Copy link
Contributor

@junghao junghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@wilsonjord wilsonjord merged commit 3702062 into main Mar 17, 2026
16 checks passed
@wilsonjord wilsonjord deleted the feat-golang-lint-update branch March 17, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants