Skip to content

Conversation

@giohappy
Copy link
Contributor

@giohappy giohappy commented Apr 10, 2025

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@giohappy giohappy requested a review from mattiagiupponi April 10, 2025 11:25
@giohappy giohappy self-assigned this Apr 10, 2025
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 10, 2025
@giohappy giohappy changed the title [Fixes #13055] Limit the list of pictuations used inside create-envfile.py [Fixes #13055] Limit the list of punctuations used inside create-envfile.py Apr 10, 2025
@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.97%. Comparing base (3a05aa5) to head (aa33b24).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13056   +/-   ##
=======================================
  Coverage   67.97%   67.97%           
=======================================
  Files         980      980           
  Lines       59302    59302           
  Branches     6932     6932           
=======================================
  Hits        40313    40313           
  Misses      17340    17340           
  Partials     1649     1649           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattiagiupponi mattiagiupponi merged commit 7b80d4e into master Apr 11, 2025
19 checks passed
@mattiagiupponi mattiagiupponi deleted the issue_13055 branch April 11, 2025 07:50
github-actions bot pushed a commit that referenced this pull request Apr 11, 2025
(cherry picked from commit 7b80d4e)
mattiagiupponi pushed a commit that referenced this pull request Apr 11, 2025
(cherry picked from commit 7b80d4e)

Co-authored-by: Giovanni Allegri <giohappy@gmail.com>
@giohappy giohappy linked an issue Apr 14, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 4.4.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limit the list of punctuations used inside create-envfile.py

3 participants