Skip to content

[Fixes #13102] Define a specific version of the Wheel package#13104

Merged
giohappy merged 1 commit intomasterfrom
ISSUE_13102
Apr 16, 2025
Merged

[Fixes #13102] Define a specific version of the Wheel package#13104
giohappy merged 1 commit intomasterfrom
ISSUE_13102

Conversation

@Gpetrak
Copy link
Copy Markdown
Member

@Gpetrak Gpetrak commented Apr 16, 2025

This PR was created and fixes this issue: #13102
The version 0.38.1 of wheel is defined explicitly on Dockerfile of the base image because otherwise Docker installs by default the version of 0.37.1

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@Gpetrak Gpetrak added dependencies Pull requests that update a dependency file backport 4.4.x labels Apr 16, 2025
@Gpetrak Gpetrak added this to the 5.0.0 milestone Apr 16, 2025
@Gpetrak Gpetrak requested a review from giohappy April 16, 2025 08:26
@Gpetrak Gpetrak self-assigned this Apr 16, 2025
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 16, 2025
@Gpetrak Gpetrak linked an issue Apr 16, 2025 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.82%. Comparing base (8677a7f) to head (bb7e3e0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13104      +/-   ##
==========================================
+ Coverage   61.60%   67.82%   +6.22%     
==========================================
  Files         979      979              
  Lines       57465    57465              
  Branches     6632     6632              
==========================================
+ Hits        35399    38974    +3575     
+ Misses      20570    16923    -3647     
- Partials     1496     1568      +72     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giohappy giohappy merged commit 56a4272 into master Apr 16, 2025
20 checks passed
@giohappy giohappy deleted the ISSUE_13102 branch April 16, 2025 09:02
github-actions bot pushed a commit that referenced this pull request Apr 16, 2025
giohappy pushed a commit that referenced this pull request Apr 16, 2025
…13105)

(cherry picked from commit 56a4272)

Co-authored-by: George Petrakis <gkpetrak@gmail.com>
@mattiagiupponi mattiagiupponi removed this from the 5.0.0 milestone Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 4.4.x cla-signed CLA Bot: community license agreement signed dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Wheel to 0.38.1 on Docker

3 participants