[Fixes #14061] Upsert does not work after performing a replace on the…

[mattiagiupponi]

… resource

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
• New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where upsert operations failed after a resource replacement. The fix involves refining the resource handling logic during overwrite scenarios by ensuring that the __fixup_primary_key operation is correctly applied within the fixup_dynamic_model_fields method, using the appropriate resource context. This change guarantees that the primary key is properly synchronized after dynamic model field adjustments, resolving the reported upsert issue.

Highlights

• Parameter Update: The create_geonode_resource Celery task now passes the resource object to the handler.fixup_dynamic_model_fields method during resource overwrite operations.
• Method Signature Change: The fixup_dynamic_model_fields method in both raster and vector handlers was updated to accept arbitrary keyword arguments (**kwargs), allowing for more flexible parameter passing.
• Primary Key Fixup Relocation: The call to __fixup_primary_key in the vector handler was moved from refresh_geonode_resource into fixup_dynamic_model_fields, ensuring it is executed with the correct resource context during dynamic model field synchronization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug where an upsert operation fails after a replace operation on a resource. The changes move the __fixup_primary_key call to fixup_dynamic_model_fields, which is part of the 'replace' flow, to ensure the primary key is properly configured. The resource object is now passed to this method, and relevant handler signatures have been updated. The changes appear to correctly address the described issue.

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.49%. Comparing base (7f6c030) to head (a166fac).
⚠️ Report is 24 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #14062      +/-   ##
==========================================
+ Coverage   74.07%   74.49%   +0.42%     
==========================================
  Files         950      951       +1     
  Lines       56826    57367     +541     
  Branches     7719     7783      +64     
==========================================
+ Hits        42093    42736     +643     
+ Misses      13044    12920     -124     
- Partials     1689     1711      +22     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.