[Fixes #14136] Fixes the support for creation of dataset with generic Geometry type#14137
Open
[Fixes #14136] Fixes the support for creation of dataset with generic Geometry type#14137
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements support for generic 'Geometry' types within vector handlers and empty dataset utilities, mapping them to Django's GeometryField and GeoServer's JTS Geometry binding. It also updates the setup_dynamic_model method to support layer names provided as strings. A review comment suggests updating the type hint for the layer parameter in setup_dynamic_model to include str for better type safety and clarity.
mattiagiupponi
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14136
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.