Skip to content

[Fixes #14134] Migrate userinfo endpoint to DRF#14140

Open
nrjadkry wants to merge 2 commits intomasterfrom
ISSUE_14134
Open

[Fixes #14134] Migrate userinfo endpoint to DRF#14140
nrjadkry wants to merge 2 commits intomasterfrom
ISSUE_14134

Conversation

@nrjadkry
Copy link
Copy Markdown
Contributor

@nrjadkry nrjadkry commented Apr 14, 2026

Fixes #14134

The new endpoint is /api/v2/userinfo/

The error response format for unauthenticated requests has been updated to follow standard procedure. Here is the example of the response in case of unauthenticated user

Previous:

{
    "success": false,
    "status": "error",
    "errors": {
        "user": [
            "User is not authenticated"
        ]
    }
}

Current:

{
  "success": false,
  "errors": [
    "Authentication credentials were not provided."
  ],
  "code": "not_authenticated"
} 

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the user_info endpoint from a function-based view to a Django Rest Framework class-based view (UserInfoView). While the transition to DRF improves the code structure, the original implementation's CSRF exemption was omitted in the new class-based view. Feedback suggests restoring this exemption using @method_decorator(csrf_exempt, name='dispatch') to maintain compatibility with existing clients and ensure functional parity with the previous implementation.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate userinfo endpoint to DRF

2 participants