Skip to content

[Fixes #14158] Fixes export of tabular dataset#14159

Merged
mattiagiupponi merged 1 commit intomasterfrom
ISSUE_14158
Apr 23, 2026
Merged

[Fixes #14158] Fixes export of tabular dataset#14159
mattiagiupponi merged 1 commit intomasterfrom
ISSUE_14158

Conversation

@sijandh35
Copy link
Copy Markdown
Contributor

Fixes #14158

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Apr 22, 2026
@sijandh35 sijandh35 requested a review from giohappy April 22, 2026 14:41
@sijandh35 sijandh35 assigned sijandh35 and unassigned sijandh35 Apr 22, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the can_have_wfs_links property in geonode/base/models.py to include the tabular subtype. Feedback suggests also including the vector_time subtype to maintain consistency with other properties and ensure that vector time resources, which are served via WFS, correctly support WFS links.

Comment thread geonode/base/models.py
@property
def can_have_wfs_links(self):
return self.subtype == "vector"
return self.subtype in {"vector", "tabular"}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding tabular support is correct for fixing the export of tabular datasets, vector_time should also be included in can_have_wfs_links. vector_time is a vector subtype (as defined in Dataset.is_vector) and resources of this type are served via WFS by GeoServer, thus they should support WFS links for export and download. This ensures consistency with can_be_downloaded and can_have_wps_links which already include vector_time.

Suggested change
return self.subtype in {"vector", "tabular"}
return self.subtype in {"vector", "vector_time", "tabular"}

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.55%. Comparing base (94ca636) to head (732ab64).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14159      +/-   ##
==========================================
- Coverage   74.62%   74.55%   -0.07%     
==========================================
  Files         958      958              
  Lines       57891    58043     +152     
  Branches     7889     7920      +31     
==========================================
+ Hits        43202    43276      +74     
- Misses      12927    13000      +73     
- Partials     1762     1767       +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattiagiupponi mattiagiupponi merged commit 4327fd8 into master Apr 23, 2026
17 of 18 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_14158 branch April 23, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export Data Dropdown Is Empty for Tabular Datasets

2 participants