[Fixes #14274] Enable importing a remote resource from a private WMS service#14285
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for authentication configurations when importing remote WMS services, updating serializers, thumbnail generation, and resource payload generation to handle credentials, alongside adding corresponding unit tests. The review feedback highlights several critical issues, including a potential runtime TypeError when instantiating AuthConfig with a non-field property, a potential DoesNotExist exception when fetching an authentication configuration, and potential ValueError exceptions if queries are performed with an unauthenticated or null user.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #14285 +/- ##
==========================================
- Coverage 74.92% 74.89% -0.04%
==========================================
Files 975 977 +2
Lines 59902 60233 +331
Branches 8157 8213 +56
==========================================
+ Hits 44884 45109 +225
- Misses 13194 13299 +105
- Partials 1824 1825 +1 🚀 New features to boost your workflow:
|
Fixes #14274
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.