Skip to content

[Fixes #14305] celery-cmd handling of CELERY__HARVESTER_MAX_MEMORY_PER_CHILD#14307

Merged
Gpetrak merged 1 commit into
GeoNode:masterfrom
jwkaltz:celery-cmd-param-typo
Jun 10, 2026
Merged

[Fixes #14305] celery-cmd handling of CELERY__HARVESTER_MAX_MEMORY_PER_CHILD#14307
Gpetrak merged 1 commit into
GeoNode:masterfrom
jwkaltz:celery-cmd-param-typo

Conversation

@jwkaltz

@jwkaltz jwkaltz commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Currently, the CELERY__HARVESTER_MAX_MEMORY_PER_CHILD uses the CELERY__MAX_MEMORY_PER_CHILD, so Harvester will use the same setting as the Default worker, which is not the intention, as demonstrated by the different default values (200000 vs 500000). This PR fixes this issue.

Checklist

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

@cla-bot

cla-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jwkaltz on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a variable fallback typo in the celery-cmd script, ensuring that CELERY__HARVESTER_MAX_MEMORY_PER_CHILD correctly defaults to its own environment variable rather than CELERY__MAX_MEMORY_PER_CHILD. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

jwkaltz added a commit to jwkaltz/geonode-k8s that referenced this pull request Jun 8, 2026
@Gpetrak Gpetrak self-requested a review June 8, 2026 12:14
@Gpetrak Gpetrak assigned Gpetrak and mattiagiupponi and unassigned Gpetrak Jun 8, 2026
@mattiagiupponi

Copy link
Copy Markdown
Contributor

Hi @jwkaltz thanks for the PR
i added you in the .clabot, please pull the changes from master branch, so the clabot will no longer add the message

@Gpetrak Gpetrak merged commit 929ad55 into GeoNode:master Jun 10, 2026
17 of 18 checks passed
mattiagiupponi pushed a commit that referenced this pull request Jun 10, 2026
(cherry picked from commit 929ad55)

Co-authored-by: Wolfgang Kaltz <jwkaltz70@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

celery-cmd script wrong handling of CELERY__HARVESTER_MAX_MEMORY_PER_CHILD

3 participants