[Fixes #14305] celery-cmd handling of CELERY__HARVESTER_MAX_MEMORY_PER_CHILD#14307
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jwkaltz on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
There was a problem hiding this comment.
Code Review
This pull request corrects a variable fallback typo in the celery-cmd script, ensuring that CELERY__HARVESTER_MAX_MEMORY_PER_CHILD correctly defaults to its own environment variable rather than CELERY__MAX_MEMORY_PER_CHILD. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Hi @jwkaltz thanks for the PR |
Currently, the CELERY__HARVESTER_MAX_MEMORY_PER_CHILD uses the CELERY__MAX_MEMORY_PER_CHILD, so Harvester will use the same setting as the Default worker, which is not the intention, as demonstrated by the different default values (200000 vs 500000). This PR fixes this issue.
Checklist
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):