Skip to content

[Backport to 2.10.x][Fixes #5849] Read Only and Maintenance modes#5989

Merged
afabiani merged 5 commits intoGeoNode:2.10.xfrom
bieganowski:modes_backport
Apr 9, 2020
Merged

[Backport to 2.10.x][Fixes #5849] Read Only and Maintenance modes#5989
afabiani merged 5 commits intoGeoNode:2.10.xfrom
bieganowski:modes_backport

Conversation

@bieganowski
Copy link
Copy Markdown
Contributor

Backport of Read-Only and Maintenance modes

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@bieganowski bieganowski requested review from afabiani and giohappy April 9, 2020 09:33
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Apr 9, 2020
@giohappy giohappy removed their request for review April 9, 2020 09:36
@bieganowski bieganowski requested a review from giohappy April 9, 2020 09:45
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2020

Codecov Report

Merging #5989 into 2.10.x will increase coverage by 0.25%.
The diff coverage is 82.85%.

@@            Coverage Diff             @@
##           2.10.x    #5989      +/-   ##
==========================================
+ Coverage   57.09%   57.35%   +0.25%     
==========================================
  Files         176      178       +2     
  Lines       19650    19719      +69     
  Branches     3079     3090      +11     
==========================================
+ Hits        11220    11310      +90     
+ Misses       7455     7426      -29     
- Partials      975      983       +8     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants