Conversation
Member
|
David, you are my hero. +2 (Assuming all existing tests pass) |
Contributor
|
I certainly like this refactor to remove the layerController with the ?describe ?remove etc pattern, but I noticed when implementing this same pattern for remove services, I noticed that the profile page is still setup to use this old pattern, and so doesnt work with the refactor. https://github.com/GeoNode/geonode/blob/master/src/GeoNodePy/geonode/templates/profiles/profile_detail.html#L97 ... Seems like we need to refactor the map_controller and then update this template to follow the new pattern. |
gubuntu
pushed a commit
to gubuntu/geonode
that referenced
this pull request
May 15, 2017
Geosafe package
travislbrundage
pushed a commit
to travislbrundage/geonode
that referenced
this pull request
Jul 27, 2017
Adjust promise resolution with angular bump to 1.6.5
abulojoshua1
added a commit
to abulojoshua1/geonode
that referenced
this pull request
Sep 2, 2020
marthamareal
pushed a commit
to marthamareal/geonode
that referenced
this pull request
Sep 24, 2021
Closes GeoNode#69 It checks feature edit permission on layer base
marthamareal
pushed a commit
to marthamareal/geonode
that referenced
this pull request
Sep 24, 2021
* update documentation * update homepage resource types list and resource enpoint * update client bundle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's work on making GeoNode a well-behaved citizen of the Django community.