Skip to content

Fix deeplearning autoencoder implementation issues#151

Merged
tausiaj merged 3 commits into
GeoOcean:developfrom
sergioald:fix-autoencoder-implementation
Jul 3, 2026
Merged

Fix deeplearning autoencoder implementation issues#151
tausiaj merged 3 commits into
GeoOcean:developfrom
sergioald:fix-autoencoder-implementation

Conversation

@sergioald

Copy link
Copy Markdown
Collaborator

This PR fixes the implementation issues documented by the autoencoder smoke tests.

Changes include:

  • Fix StandardAutoencoder and OrthogonalAutoencoder multidimensional flatten/reconstruction handling
  • Add a ViT decoder projection from d_model tokens back to patch-dimension tokens before Unpatchify
  • Make ConvLSTMAutoencoder reconstruct the last frame by default when y is not provided
  • Make HybridConvLSTMTransformerAutoencoder reconstruct the last frame by default when y is not provided
  • Store efficient_attention in the hybrid inner model
  • Pass ConvLSTM kernel_size as a tuple
  • Use deepcopy for best model state restoration

Local test result on Windows / Anaconda:
213 passed.

@sergioald sergioald requested a review from tausiaj July 1, 2026 11:42
@sergioald

Copy link
Copy Markdown
Collaborator Author

Hi @tausiaj,

The CI checks have passed. This PR is ready for review.

It includes the autoencoder smoke tests and the implementation fixes discussed in the PR description. I also verified the full test suite locally on Windows/Anaconda with:

213 passed.

Happy to make any changes if you prefer a different design for the ConvLSTM/Hybrid reconstruction target or the StandardAutoencoder flattening behaviour.

After this PR, I would be happy to contribute follow-up improvements in separate PRs, for example reconstruction-error utilities, PCA/autoencoder comparison examples, or anomaly-detection examples for climate/ocean data.

@tausiaj tausiaj merged commit 2129c41 into GeoOcean:develop Jul 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants