Skip to content

Surface GBQ errors during getJobStatus stage#217

Merged
aaront merged 1 commit into
Geotab:mainfrom
sanyamguptageotab:ITS-11608/surface-job-status-errors
Jun 2, 2026
Merged

Surface GBQ errors during getJobStatus stage#217
aaront merged 1 commit into
Geotab:mainfrom
sanyamguptageotab:ITS-11608/surface-job-status-errors

Conversation

@sanyamguptageotab
Copy link
Copy Markdown
Contributor

Summary

  • Surface BigQuery errorResult returned during the getJobStatus stage so failures are reported instead of silently passing through.
  • When a job's status contains an errorResult, build a DaasError from its code/location/message, append it to errors, and force the state to FAILED.

Test plan

  • Verify a job that finishes with a BigQuery errorResult is reported as FAILED with the error surfaced.
  • Verify a successful job (no errorResult) still resolves normally.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.80%. Comparing base (de63bb9) to head (0f3235f).

Files with missing lines Patch % Lines
mygeotab/altitude/daas_definition.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
- Coverage   55.31%   54.80%   -0.51%     
==========================================
  Files           9        9              
  Lines         546      551       +5     
  Branches       89       90       +1     
==========================================
  Hits          302      302              
- Misses        222      227       +5     
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aaront aaront merged commit 895742f into Geotab:main Jun 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants