Skip to content

Conversation

@Roey7
Copy link
Contributor

@Roey7 Roey7 commented Mar 26, 2023

No description provided.

@Itaykal
Copy link
Contributor

Itaykal commented Mar 27, 2023

I think it would be safer for the data_source API to stay in a separate folder from the sources.
Another option is to create app/data_source/data_source_api or app/data_source/data_source_sdk
but leaving it as files in the data_source folder could lead to issues when trying to expand the api/sdk whatever you want to call it

app/slaves.py Outdated

@classmethod
def start(cls):
for i in range(0, 20):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • make this a constant, also remove the 0

@Roey7 Roey7 merged commit 964e859 into main Mar 27, 2023
@Roey7 Roey7 deleted the task-queue branch March 27, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants