Skip to content

3ds Theme support.#1

Merged
Gericom merged 13 commits into
Gericom:masterfrom
clienthax:master
Nov 17, 2014
Merged

3ds Theme support.#1
Gericom merged 13 commits into
Gericom:masterfrom
clienthax:master

Conversation

@clienthax
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Clienthax <clienthax@gmail.com>
Signed-off-by: Clienthax <clienthax@gmail.com>
Signed-off-by: Clienthax <clienthax@gmail.com>
@Gericom
Copy link
Copy Markdown
Owner

Gericom commented Nov 14, 2014

It looks nice, but you need to change some stuff in the identifier. You need to change some things in the ThemeIdentifier. I would change GetCategory into 3DS Themes, the file description is not very descriptive and the filter is a bit too long. Also, currently it sees every file as theme . You need to make it detect the theme file in IsFormat. Also, decompression is not needed. Which compression is used? Because efe will auto decompress.

@clienthax
Copy link
Copy Markdown
Collaborator Author

Theres no way to detect the header as it has no magic,
i wasn't sure how the filter worked, and it uses lz11 compression,

@Gericom
Copy link
Copy Markdown
Owner

Gericom commented Nov 14, 2014

Then you can use a file name for detection. (look at obj in commonfiles)
I will implement LZ11 soon, so it will work then for the compressed ones aswell. You can remove the 'decompressed' part from the file filter.

Signed-off-by: Clienthax <clienthax@gmail.com>
Signed-off-by: Clienthax <clienthax@gmail.com>
@clienthax
Copy link
Copy Markdown
Collaborator Author

there ya go

@Gericom
Copy link
Copy Markdown
Owner

Gericom commented Nov 14, 2014

It's FormatMatch.Extension (because content is more important than a name).
The filter is okay now. Only add 3DS at the start. I would only change GetFileDescription into 3DS System Menu Theme (body_LZ.bin)

After that, I think it's okay. I will test it tomorrow when I am on my pc. Could you send me an example of a theme?

@clienthax
Copy link
Copy Markdown
Collaborator Author

ping me on #3dsdev efnet

Signed-off-by: Clienthax <clienthax@gmail.com>
Signed-off-by: Clienthax <clienthax@gmail.com>
Signed-off-by: Clienthax <clienthax@gmail.com>
Signed-off-by: Clienthax <clienthax@gmail.com>
Signed-off-by: Clienthax <clienthax@gmail.com>
Signed-off-by: Clienthax <clienthax@gmail.com>
Gericom added a commit that referenced this pull request Nov 17, 2014
@Gericom Gericom merged commit 1d5730a into Gericom:master Nov 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants