Skip to content

Allow scheduling sessions without end time#129

Open
GestureGraphix wants to merge 1 commit intomainfrom
codex/remove-end-time-from-workout-session
Open

Allow scheduling sessions without end time#129
GestureGraphix wants to merge 1 commit intomainfrom
codex/remove-end-time-from-workout-session

Conversation

@GestureGraphix
Copy link
Copy Markdown
Owner

Summary

  • make session end times optional in shared types and role context logic so sessions can be scheduled with only a start
  • update athlete training and coach dashboard flows to remove end time inputs and gracefully display sessions without an end
  • adjust formatters and normalization helpers to handle missing end timestamps across the app

Testing

  • npm run lint

https://chatgpt.com/codex/tasks/task_e_6906a619249c8323902410fdcb667550

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Nov 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
locker Ready Ready Preview Comment Nov 2, 2025 0:40am

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 1401 to +1405
focus,
}

if (normalizedEndAt) {
newSession.endAt = normalizedEndAt
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Clearing end time in edits is impossible

After the UI changes, athletes and coaches can no longer supply endAt when editing a session; however, the update path still retains the previous endAt by default (const normalizedEndAt = endAtISO || existingSession?.endAt). This means rescheduling an existing session to a new start time keeps its old end timestamp, potentially leaving the session ending before it starts or on the wrong day, and there is no way for a user to remove or correct it through the UI. Consider dropping the existing endAt when no new value is provided so that edits don’t preserve stale end times.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant