Allow scheduling sessions without end time#129
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| focus, | ||
| } | ||
|
|
||
| if (normalizedEndAt) { | ||
| newSession.endAt = normalizedEndAt |
There was a problem hiding this comment.
Clearing end time in edits is impossible
After the UI changes, athletes and coaches can no longer supply endAt when editing a session; however, the update path still retains the previous endAt by default (const normalizedEndAt = endAtISO || existingSession?.endAt). This means rescheduling an existing session to a new start time keeps its old end timestamp, potentially leaving the session ending before it starts or on the wrong day, and there is no way for a user to remove or correct it through the UI. Consider dropping the existing endAt when no new value is provided so that edits don’t preserve stale end times.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_6906a619249c8323902410fdcb667550