fix: move from __future__ import to top of did_agent_extension.py#511
Closed
Subhajitdas99 wants to merge 2 commits intoGetBindu:mainfrom
Closed
fix: move from __future__ import to top of did_agent_extension.py#511Subhajitdas99 wants to merge 2 commits intoGetBindu:mainfrom
Subhajitdas99 wants to merge 2 commits intoGetBindu:mainfrom
Conversation
from __future__ import annotations must appear before all other imports. It was placed after import os and import platform, causing SyntaxError at import time and breaking all unit tests across the repo.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from __future__ import annotationswas placed afterimport osandimport platformindid_agent_extension.py, causing aSyntaxErrorat import time.bindu.serverfails because the import chain reachesdid_agent_extension.py.from __future__ import annotationsto line 28 — immediately after the module docstring, before all other imports. This is required by Python.Change Type
Scope
Impact
This single fix unblocks CI for all open PRs that were showing unit test failures due to this SyntaxError.
Checklist
from bindu.extensions.did.did_agent_extension import DIDAgentExtensionimports cleanly