-
Notifications
You must be signed in to change notification settings - Fork 171
Open
Labels
Good First Issuegood issues for first time contributorsgood issues for first time contributorsNeeds test
Description
This is a follow-up to #4359 where we discovered that MysqlImport::runIt() checks for the existence of a file, and this behavior wasn't covered by a test.
This gives us two things to do:
- Generate test coverage for:
// Attempt to resolve resource file name from file path.
if (($file_path = \Drupal::service('file_system')->realpath($this->resource->getFilePath(TRUE))) === FALSE) {
return $this->setResultError(sprintf(
'Unable to resolve file name "%s" for resource with identifier "%s".',
$this->resource->getFilePath(TRUE),
$this->resource->getUniqueIdentifier())
);
}
- Determine why
MysqlImportperforms this check on the file, butImportJobdoes not. If needed, turn this file check into a separate method on ImportJob and then both subclasses can use it.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Good First Issuegood issues for first time contributorsgood issues for first time contributorsNeeds test