skill: call.ended fires on cancel; filter by callId#4
Merged
Conversation
The call.ended event is now driven by the call's terminal status, so it fires on any termination (completed / failed / cancelled) and carries the terminal `status` plus a `canceled` flag. Also fixes the wait-for example filter: the event field is camelCase `callId` (what `dial call` prints and the listen log carries), not `call_id` — the old snake_case filter would never have matched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
call.endedevent is moving to being driven by the call's terminal status (server-side change), so it now fires on any termination — completed, failed, or cancelled — and carries the terminalstatusplus acanceledflag.This updates the agent-facing skill's "react to a call ending" signpost to say so, and fixes a latent bug in the example:
dial wait-for call.ended -f call_id=<id>→-f callId=<id>. The event field is camelCasecallId(whatdial callitself prints and what the listen log carries); the oldcall_idfilter would never match.Spec-first ordering
Contract lands first in GENWAY-AI/dial-docs#15. The monorepo PR (server + sdk-node) bumps this
clisubmodule pointer once this merges.🤖 Generated with Claude Code