chore(offline_first_with_supabase): Catching AuthRetryableFetchException to ignore it on any action that does not have the remote policy#615
Merged
tshedor merged 1 commit intoGetDutchie:mainfrom Jul 2, 2025
Conversation
tshedor
requested changes
Jul 1, 2025
| OfflineFirstDeletePolicy policy = OfflineFirstDeletePolicy.optimisticLocal, | ||
| Query? query, | ||
| }) async { | ||
| Exception? caughtException; |
Collaborator
There was a problem hiding this comment.
tbh I'd rather be anti-DRY than make an extra assignment. Could you please throw instead?
Contributor
Author
There was a problem hiding this comment.
Updated to the more straightforward (less DRY) code.
| PostgresChangeFilter? queryToPostgresChangeFilter<TModel extends TRepositoryModel>( | ||
| Query query, | ||
| ) { | ||
| PostgresChangeFilter? queryToPostgresChangeFilter<TModel extends TRepositoryModel>(Query query) { |
Collaborator
There was a problem hiding this comment.
My personal IDE is also set to 100 line length, but pub.dev grades you on having their formatting. So you'll need to format this file at an 80 character line length.
Contributor
Author
There was a problem hiding this comment.
It was hard to keep the previous formatted, my VS was chosing a different formatting style when set to 80 so almost every 2 lines I had a change. I formatted it by hand.
Do you have any formatting configuration you could share? (besides the one in .vscode already)
| OfflineFirstUpsertPolicy policy = OfflineFirstUpsertPolicy.optimisticLocal, | ||
| Query? query, | ||
| }) async { | ||
| Exception? caughtException; |
stefanorumi7
force-pushed
the
feature/auth_retryable_fetch_exception_ignored
branch
from
8f2065b to
fba4e52
Compare
…ion to ignore it on any action that does not have the remote policy
stefanorumi7
force-pushed
the
feature/auth_retryable_fetch_exception_ignored
branch
from
fba4e52 to
9e948e7
Compare
tshedor
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution to issue #607 . Solving the following exception in OfflineFirst Supabase repositories: