chore(components): Add additional Page visual tests before refactor.#2866
Merged
chore(components): Add additional Page visual tests before refactor.#2866
Conversation
Deploying atlantis with
|
| Latest commit: |
f250a74
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4e8cc806.atlantis.pages.dev |
| Branch Preview URL: | https://cleanup-page-refactor-visual.atlantis.pages.dev |
Contributor
|
@scotttjob , I was going to approve this PR and ask you to merge it. But there are a bunch of conflicts. Could you please fix them? Or would you prefer if I did that? |
nad182
requested changes
Feb 10, 2026
Contributor
nad182
left a comment
nad182
left a comment
There was a problem hiding this comment.
Conflicts. Otherwise looks good!
nad182
reviewed
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Looks like this file might have been auto-formatted. I can revert this change, but my preference would be to keep it, since it will inevitably appear again later.
nad182
reviewed
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Same auto-formatting happened as above. My preference is to keep it, since it's a very small change.
nad182
reviewed
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Same auto-formatting happened as above. My preference is to keep it, since it's a very small change.
jdeichert
approved these changes
Feb 12, 2026
nad182
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations
Wanted to do a PoC run of refactoring Page to use composed parts. We've been mentioning building more visual tests before that kind of a refactor, so this is step 1 towards that!
Changes
Added
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.