fix(components-native): Fix styling of checkbox [JOB-152492]#2936
fix(components-native): Fix styling of checkbox [JOB-152492]#2936Aiden-Brine merged 2 commits intomasterfrom
Conversation
Deploying atlantis with
|
| Latest commit: |
31c8da6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://61748b35.atlantis.pages.dev |
| Branch Preview URL: | https://job-152492-checkbox-label.atlantis.pages.dev |
| justifyContent: "space-between", | ||
| flexDirection: "row", | ||
| alignItems: "center", | ||
| minHeight: tokens["space-largest"], |
There was a problem hiding this comment.
Nit: there is guidance in the docs about not coupling UI element size to spacing
| minHeight: tokens["space-largest"], | |
| minHeight: 48, |
This aside, will try and test in-app for verification but the changes seem like they should resolve the issue
There was a problem hiding this comment.
Good catch, updated and merged. @chris-at-jobber once the tentpole codefreeze is over I will make sure this gets merged to JM
|
Published Pre-release for f0531e5 with versions: To install the new version(s) for Mobile run: |
Aiden-Brine
changed the title
|
In-app testing looks good as well and is now a clean match to the Figma ✅ Also verified some instances with description still look as expected 
|
chris-at-jobber
left a comment
chris-at-jobber
left a comment
There was a problem hiding this comment.
Design approved from my end
nad182
left a comment
nad182
left a comment
There was a problem hiding this comment.
I'm preemptively approving this PR - chatted offline that the minHeight value would be updated to 48 according to our docs that @chris-at-jobber pointed out.
|
🫡 |
3 participants
Motivations
It was pointed out that the component height and label alignment for Checkbox do not match the Figmas.
Code:
Figma:
Changes
Added
Added a min-height of
space-largestChanged
Changed the alignment to
"center"when there is no descriptive text and kept it at"flex-start"when there is which matches the Figma designsTesting
Check out the component in storybook and ensure it behaves as expected
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.