feat(components): Remove v1 Select#3065
Merged
Merged
Conversation
jdeichert
commented
Apr 15, 2026
|
|
||
| #### OptionGroup Props | ||
|
|
||
| <ArgsTable of={Select.OptionGroup} /> |
Contributor
Author
There was a problem hiding this comment.
These sections are currently empty on production: https://atlantis.getjobber.com/components/Select
On this branch, they now appear on the Web props table page.
Deploying atlantis with
|
| Latest commit: |
00671d9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a34f6604.atlantis.pages.dev |
| Branch Preview URL: | https://job-145588-remove-v1-select.atlantis.pages.dev |
jdeichert
changed the title
Using this as an aid in the migration effort.
|
Published Pre-release for 3eacbe4 with versions: To install the new version(s) for Web run: |
jdeichert
commented
Apr 15, 2026
This reverts commit 3eacbe4.
v6 branch is official
MichaelParadis
requested changes
May 5, 2026
Contributor
MichaelParadis
left a comment
MichaelParadis
left a comment
There was a problem hiding this comment.
Overall looks good. The only thing I noticed was that you didn't remove it from usage-guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why Is This Changing?
This PR deletes the V1 implementation of
Select.What Is Changing?
Consumer Impact
Validation
Reviewer Notes
Changes can be tested via Pre-release
In Atlantis we use Github's built in pull request reviews.