feat(components): Remove v1 InputDate#3133
Conversation
|
Published Pre-release for 60feac6 with versions: To install the new version(s) for Web run: |
Deploying atlantis with
|
| Latest commit: |
76620e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73f1f038.atlantis.pages.dev |
| Branch Preview URL: | https://job-145592-make-inputdate-v2.atlantis.pages.dev |
| @@ -9,7 +9,7 @@ import { Button } from "../Button"; | |||
| import { Text } from "../Text"; | |||
There was a problem hiding this comment.
My strategy was to copy/paste the rebuilt tests into this file, to replace these.
Looks like you took a different approach here. Curious how did you handle this?
There was a problem hiding this comment.
I manually compared them.
I initially did the rename of the component and ran the old tests (just to see if the old ones passed because in theory they should) there was a failure with should show mini calendar when set to false and down arrow is pressed (the keydown vs keyup change).
As a result I manually went through the files (old on left side of my screen and new one on the right) to see if something was missed in the v2 tests that was in the v1 tests. There wasn't but I would rather be safe than sorry.
jdeichert
left a comment
jdeichert
left a comment
There was a problem hiding this comment.
Looks great!
Let's chat about rollout strategy 👍
2 participants
Why Is This Changing?
This PR deletes the V1 implementation of
InputDate.What Is Changing?
Consumer Impact
Validation
Reviewer Notes
Changes can be tested via Pre-release
In Atlantis we use Github's built in pull request reviews.