Skip to content

Sync fork with upstream auth0/omniauth-auth0 v3.2.0#4

Merged
pontiphex merged 32 commits into
masterfrom
chore/sync-upstream-v3.2.0
May 28, 2026
Merged

Sync fork with upstream auth0/omniauth-auth0 v3.2.0#4
pontiphex merged 32 commits into
masterfrom
chore/sync-upstream-v3.2.0

Conversation

@pontiphex
Copy link
Copy Markdown
Collaborator

Summary

Brings our fork up to date with upstream auth0/omniauth-auth0 v3.2.0. The fork had drifted ~31 commits behind (it was sitting on a v3.1.1-era base plus our one customization). This merges upstream master while preserving our only real change: forwarding ext- prefixed query params to /authorize.

Why now

We want a feature from upstream v3.2.0:

Also pulled in: dependency bumps (faraday, rack, rexml), the new RL/release CI workflows, README/CHANGELOG updates, and the JWTToken helper.

Our customization, preserved

  • lib/omniauth/strategies/auth0.rb: authorize_params still forwards any ext-prefixed param (Auth0's custom query parameter convention) via the is_authorized_param? helper, now sitting alongside upstream's new client-assertion private methods.

Conflict resolution notes

  • Strategy file: kept both our is_authorized_param? helper and upstream's new client_assertion_* methods.
  • Spec file: upstream refactored the redirect tests into the shared example group oauth redirects with various parameters, run under two auth contexts (client_secret and client-assertion). I folded our ext- assertions + the ext-test=testval example into that shared group, so our customization is now exercised under both contexts (better coverage than the original single-context tests).
  • Gemfile.lock: took upstream's resolution; our stale dependabot bump is superseded. Lockfile is now byte-identical to upstream.

The net diff vs upstream master is exactly the ext- customization (lib + spec), nothing else.

Test plan

  • bundle exec rspec128 examples, 0 failures (99.36% line coverage)
  • Strategy spec specifically — 68 examples, 0 failures; ext-test cases pass under both auth contexts
  • ruby -c syntax check on resolved files
  • After merge, repoint the Jobber monolith's omniauth-auth0 git dependency at the new master (or this merge SHA) and run the app's auth specs

Follow-up (separate, not this PR)

Upstream issue auth0#214 requests this exact ext- feature and references the previously-withdrawn auth0#204. Worth reviving as a clean, configurable upstream PR so we can eventually drop the fork — tracked separately.

🤖 Generated with Claude Code

stevenwong-okta and others added 30 commits July 25, 2024 22:29
Bumps [faraday](https://github.com/lostisland/faraday) from 2.7.10 to 2.14.1.
- [Release notes](https://github.com/lostisland/faraday/releases)
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md)
- [Commits](lostisland/faraday@v2.7.10...v2.14.1)

---
updated-dependencies:
- dependency-name: faraday
  dependency-version: 2.14.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [rack](https://github.com/rack/rack) from 2.2.7 to 2.2.23.
- [Release notes](https://github.com/rack/rack/releases)
- [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md)
- [Commits](rack/rack@v2.2.7...v2.2.23)

---
updated-dependencies:
- dependency-name: rack
  dependency-version: 2.2.23
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…tinuing to support client secret authentication.

The client assertion signing key allows Private Key JWT application authentication in Auth0.  The client_assertion_signing_key and client_assertion_signing_algorithm are optional parameters.
Client assercition signing key will be used if a client_assertion_signing_key is privided. The client_assertion_signing_algorithm is optional. The algorithm defaults to RS256 if nil or not
provided.
arpit-jn and others added 2 commits May 28, 2026 19:53
Brings the fork up to date with upstream v3.2.0, which adds client
assertion signing key authentication (auth0#203) plus dependency and CI/release
workflow updates. The fork's only customization -- forwarding `ext-`
prefixed query params to /authorize -- is preserved.

Conflicts resolved:
- lib/omniauth/strategies/auth0.rb: kept the `ext-` passthrough in
  authorize_params and the is_authorized_param? helper alongside upstream's
  new client-assertion private methods.
- spec/omniauth/strategies/auth0_spec.rb: upstream refactored the redirect
  tests into the shared example group 'oauth redirects with various
  parameters' run under two auth contexts. Folded the ext- assertions and
  the ext-test=testval example into that shared group so they now run under
  both client_secret and client-assertion auth.
- Gemfile.lock: took upstream's resolution (fork's stale dependabot bump
  superseded).

Full suite: 128 examples, 0 failures.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@jobbiebot jobbiebot Bot added the approved label May 28, 2026
@pontiphex pontiphex merged commit ff6acdd into master May 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants