Error handling for task definitions created with create_service command #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoan
reviewed
Dec 15, 2022
|
|
||
| def _current_task_defn(self, ecs_client: EcsClient, deployment: DeployAction): | ||
| if not ecs_client.list_task_definitions(self._task_defn_family()): | ||
| log_err("Task definition was created with the help of the create_service\ntry updating with 'update_service' command") |
Contributor
There was a problem hiding this comment.
This task definition was created for a service. Please use cloudlift update_service to modify it.
shoan
approved these changes
Dec 16, 2022
shoan
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.