Skip to content

Pass provider to HuggingFace#276

Merged
Nash0x7E2 merged 2 commits intomainfrom
chore/ci-aws
Dec 30, 2025
Merged

Pass provider to HuggingFace#276
Nash0x7E2 merged 2 commits intomainfrom
chore/ci-aws

Conversation

@Nash0x7E2
Copy link
Member

@Nash0x7E2 Nash0x7E2 commented Dec 30, 2025

Summary by CodeRabbit

  • New Features

    • HuggingFace LLM now supports proper provider configuration with improved type handling.
  • Tests

    • Added skip logic for long-running integration tests in AWS and HuggingFace plugins to optimize test execution.

✏️ Tip: You can customize this high-level summary in your review settings.

@Nash0x7E2 Nash0x7E2 self-assigned this Dec 30, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 30, 2025

📝 Walkthrough

Walkthrough

This pull request adds test-skipping decorators to long-running AWS and HuggingFace integration tests, updates the HuggingFace LLM provider parameter with proper type annotations from the external library, and removes redundant provider argument specifications from test instantiations.

Changes

Cohort / File(s) Summary
Test Skipping Decorations
plugins/aws/tests/test_aws_realtime.py, plugins/huggingface/tests/test_huggingface.py
Added @skip_blockbuster decorator import and applied to TestBedrockRealtime, TestNova2Realtime, TestHuggingFaceVLM, and TestHuggingFaceLLM test classes. Removed provider="fastest" argument from HuggingFace LLM test instantiation.
Provider Parameter Typing
plugins/huggingface/vision_agents/plugins/huggingface/huggingface_llm.py
Imported PROVIDER_OR_POLICY_T from external library and updated __init__ provider parameter type from Optional[str] to Optional[PROVIDER_OR_POLICY_T]. Updated docstring and ensured provider is passed to AsyncInferenceClient constructor.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

Decorators bloom like nightshade—
skip, skip, skip—the long tests fall away.
Types sharpen their edges: strings to structures,
provider whispers through the client's throat.
Skipping stones across dark water. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: passing the provider parameter to HuggingFace's AsyncInferenceClient in the HuggingFaceLLM implementation.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Nash0x7E2 Nash0x7E2 changed the title Pass provider to HuggingFacez Pass provider to HuggingFace Dec 30, 2025
@Nash0x7E2 Nash0x7E2 merged commit 285864c into main Dec 30, 2025
10 checks passed
@Nash0x7E2 Nash0x7E2 deleted the chore/ci-aws branch December 30, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant