Skip to content

[PBE-236] add call grants event#23

Merged
su225 merged 11 commits intomainfrom
add-call-grants-event
Apr 6, 2023
Merged

[PBE-236] add call grants event#23
su225 merged 11 commits intomainfrom
add-call-grants-event

Conversation

@su225
Copy link
Copy Markdown
Contributor

@su225 su225 commented Mar 30, 2023

  • When call permissions change, we should inform the clients so that the UI components can grey out the call controls like mute audio/video/screenshare.
  • It can also be used for notifications like "host muted audio for all" etc.

@su225 su225 marked this pull request as ready for review April 3, 2023 07:37
@su225 su225 changed the title [PBE-236] add call grants event and send it with join response [PBE-236] add call grants event Apr 3, 2023
@su225 su225 requested review from tbarbugli and thesyncim April 3, 2023 07:37
@tbarbugli tbarbugli closed this Apr 3, 2023
@su225 su225 reopened this Apr 5, 2023
su225 added 2 commits April 6, 2023 14:46
# Conflicts:
#	protobuf/video/sfu/models/models.pb.go
#	protobuf/video/sfu/models/models_vtproto.pb.go
@thesyncim thesyncim self-requested a review April 6, 2023 09:17
@su225 su225 merged commit e1dfaa4 into main Apr 6, 2023
@su225 su225 deleted the add-call-grants-event branch April 6, 2023 09:46
oliverlaz added a commit to GetStream/stream-video-js that referenced this pull request Apr 17, 2023
Adds an event handler for the `callGrantsUpdated` SFU event. In
addition, the `Call` is now reactive and reacts to permission changes
--> Revoking permission would lead to stopping the appropriate track.

Related to: GetStream/protocol#23
DaemonLoki pushed a commit to GetStream/stream-video-js that referenced this pull request Apr 18, 2023
Adds an event handler for the `callGrantsUpdated` SFU event. In
addition, the `Call` is now reactive and reacts to permission changes
--> Revoking permission would lead to stopping the appropriate track.

Related to: GetStream/protocol#23
DaemonLoki pushed a commit to GetStream/stream-video-js that referenced this pull request Apr 20, 2023
Adds an event handler for the `callGrantsUpdated` SFU event. In
addition, the `Call` is now reactive and reacts to permission changes
--> Revoking permission would lead to stopping the appropriate track.

Related to: GetStream/protocol#23
@github-actions github-actions bot mentioned this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants