[VID-344]: Add metadata to rtmp ingress (software, location etc) #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces comprehensive RTMP ingestion support to our video processing pipeline. It adds a new
RTMPIngressstructure to handle RTMP stream metadata, including video dimensions, frame rates, and client information. The changes include new Makefile targets for streamlined protobuf management and updates to existing message types to support RTMP integration. This enhancement will improve our telemetry data collection for RTMP streams and provide better monitoring capabilities for video ingestion.The PR includes all necessary protobuf definitions, generated code, and serialization functions to ensure seamless integration with our existing systems.