Fixing Linking on urls #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ignore email address from generating og preview - sanitize the urls before using Linking module from react-native
vishalnarkhede
commented
Feb 25, 2021
src/components/StatusUpdateForm.js
Outdated
Comment on lines
32
to
33
| const urlRegex = /(?:[\w/:@-]+\.[\w/:@.-]*)+(?=\s|$)/g; | ||
| const emailRegex = /.*@.*/ ; |
Contributor
Author
There was a problem hiding this comment.
In discussion with Anatoly, for better regex!! Will replace it!
Contributor
There was a problem hiding this comment.
what if the url has an @ in the query params for some reason?
virdesai
reviewed
Feb 25, 2021
src/utils.js
Outdated
|
|
||
| // https://reactnative.dev/docs/linking | ||
| export const sanitizeUrlForLinking = (url) => { | ||
| if (url.indexOf('http://') === -1 && url.indexOf('https://') === -1) { |
Contributor
There was a problem hiding this comment.
pretty much the same thing
Suggested change
| if (url.indexOf('http://') === -1 && url.indexOf('https://') === -1) { | |
| if (!/^https?:\/\//.test(url)) { |
Contributor
Author
There was a problem hiding this comment.
Apparently there is http.com lol, so wanted to avoid that!!
Contributor
There was a problem hiding this comment.
alright updated it with regex
src/components/StatusUpdateForm.js
Outdated
Comment on lines
32
to
33
| const urlRegex = /(?:[\w/:@-]+\.[\w/:@.-]*)+(?=\s|$)/g; | ||
| const emailRegex = /.*@.*/ ; |
Contributor
There was a problem hiding this comment.
what if the url has an @ in the query params for some reason?
vishalnarkhede
force-pushed
the
vishal/linking-fix
branch
from
7bd4e5a to
c1178d8
Compare
vishalnarkhede
commented
Mar 5, 2021
|
|
||
| const urlRegex = /(https?:\/\/[^\s]+)/gi; | ||
|
|
||
| const urlRegex = /(?:\s|^)((?:https?:\/\/)?(?:[a-z0-9-]+(?:\.[a-z0-9-]+)+)(?::[0-9]+)?(?:\/(?:[^\s]+)?)?)/g; |
Contributor
Author
There was a problem hiding this comment.
Thanks to @AnatolyRugalev !! Works pretty well - https://regex101.com/r/3ms9WF/1/
virdesai
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ZD #9383
Fixes