make sure we handle extra data correctly with image and name fields#1
Closed
make sure we handle extra data correctly with image and name fields#1
Conversation
Member
Author
|
nevermind this not correct |
adrian09h
added a commit
that referenced
this pull request
Jul 24, 2019
adrian09h
added a commit
that referenced
this pull request
Jul 25, 2019
adrian09h
added a commit
that referenced
this pull request
Jul 29, 2019
adrian09h
added a commit
that referenced
this pull request
Aug 1, 2019
adrian09h
added a commit
that referenced
this pull request
Aug 14, 2019
adrian09h
added a commit
that referenced
this pull request
Aug 30, 2019
adrian09h
added a commit
that referenced
this pull request
Sep 3, 2019
tbarbugli
added a commit
that referenced
this pull request
Sep 9, 2019
* resend failed message * resend failed message #1 * resend failed message #2 * resend failed message #3 * avoid adding the temp message twice, small fixes * add client options and make sure we retry channel list query * remove try * fix status for sent messages * retry sleep up to 30s, give up after 100 attempts
adrian09h
added a commit
that referenced
this pull request
Sep 17, 2019
devUndef1ned
pushed a commit
that referenced
this pull request
Feb 1, 2021
…g_refac Message entity storing refac #1
3 tasks
This was referenced Apr 30, 2026
andremion
added a commit
that referenced
this pull request
May 7, 2026
Three changes to AppBottomBar (and consumers): - Add a 1.dp borderCoreSubtle top border above the bottom bar (Notion #1). Bar now has the same divider treatment as the top header. - Switch icon variants on selection (Notion #2). Active tab uses the filled icon variant (e.g. ic_message_bubble_fill, ic_thread_fill); inactive uses the line variant. AppBottomBarOptionTile gains a selectedIcon / unselectedIcon pair instead of a single icon. - Drop the Mentions tab to mirror the SwiftUI demo app's two-tab layout (Chats + Threads). Mentions feature stays available in the SDK; only the sample's bottom-bar entry is removed. ChannelsActivity loses the now-dead MentionsContent / mentionListViewModel and four imports. ChatsActivity's reverse mapping collapses ChatListContentMode.Mentions and .Channels into AppBottomBarOption.CHATS as a graceful fallback. No tab-switch animation — matches SwiftUI's default TabView behaviour and native Android BottomNavigationView, keeping the two SDKs feeling the same.
andremion
added a commit
that referenced
this pull request
May 7, 2026
Three changes to AppBottomBar (and consumers): - Add a 1.dp borderCoreSubtle top border above the bottom bar (Notion #1). Bar now has the same divider treatment as the top header. - Switch icon variants on selection (Notion #2). Active tab uses the filled icon variant (e.g. ic_message_bubble_fill, ic_thread_fill); inactive uses the line variant. AppBottomBarOptionTile gains a selectedIcon / unselectedIcon pair instead of a single icon. - Drop the Mentions tab to mirror the SwiftUI demo app's two-tab layout (Chats + Threads). Mentions feature stays available in the SDK; only the sample's bottom-bar entry is removed. ChannelsActivity loses the now-dead MentionsContent / mentionListViewModel and four imports. ChatsActivity's reverse mapping collapses ChatListContentMode.Mentions and .Channels into AppBottomBarOption.CHATS as a graceful fallback. No tab-switch animation — matches SwiftUI's default TabView behaviour and native Android BottomNavigationView, keeping the two SDKs feeling the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make usage of
extraDatamore predictable when constructing User and setUser payload.