Skip to content

Conversation

@bychkovdmitry
Copy link
Contributor

@bychkovdmitry bychkovdmitry commented Jun 28, 2022

🎯 Goal

Closes #3786

A system message can be the last message in a group if it contains the same user. As a result, the avatar is not displayed for the group.

🎨 UI Changes

Before After
image telegram-cloud-photo-size-2-5321374977376762981-y

🧪 Testing

  1. User A: Send several messages in a channel and leave the channel
  2. User B: Navigate to the channel above
  3. Ensure that an avatar is displayed for the last message

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

@bychkovdmitry bychkovdmitry marked this pull request as ready for review June 28, 2022 15:43
@bychkovdmitry bychkovdmitry requested a review from a team as a code owner June 28, 2022 15:43
@bychkovdmitry bychkovdmitry requested a review from a team June 28, 2022 15:43
Copy link
Contributor

@filbabic filbabic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☑️Reviewer Checklist

  • UI Components sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

@filbabic filbabic enabled auto-merge (squash) June 29, 2022 10:53
@filbabic filbabic merged commit 240c32c into develop Jun 29, 2022
@filbabic filbabic deleted the bugfix/3786-fix-avatars-not-shown-above-system-messages branch June 29, 2022 11:03
@filbabic filbabic linked an issue Jun 29, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avatars are not shown above system messages

3 participants