Use component factory for Giphy attachments and update design#6128
Use component factory for Giphy attachments and update design#6128
Conversation
SDK Size Comparison 📏
|
gpunto
changed the title
| .fillMaxWidth() | ||
| .height(1.dp) | ||
| .background(color = ChatTheme.colors.borders), | ||
| ChatTheme.componentFactory.GiphyAttachmentContent( |
There was a problem hiding this comment.
Just curious: Are we not providing the whole Giphy message as configurable via the component factory (with the Only visible to you and the buttons)?
There was a problem hiding this comment.
Hmm, good question. I didn't touch it because today we don't have it, but probably we should. WDYT?
There was a problem hiding this comment.
Actually nevermind, we have MessageGiphyContent in the factory
| ) | ||
| } | ||
|
|
||
| @Composable |
There was a problem hiding this comment.
Can we add the missing KDocs on public API?
gpunto
force-pushed
the
redesign/message-restructure-3
branch
from
0ee5361 to
af9a126
Compare
| android:viewportHeight="16"> | ||
| <path | ||
| android:pathData="M8,2.667C10.586,2.667 13.105,4.213 14.788,7.165C15.083,7.683 15.083,8.318 14.788,8.835C13.105,11.788 10.586,13.334 8,13.334C5.414,13.334 2.895,11.788 1.212,8.835C0.917,8.318 0.917,7.683 1.212,7.165C2.895,4.213 5.414,2.667 8,2.667ZM5.583,8C5.583,6.666 6.665,5.584 8,5.584C9.335,5.584 10.417,6.666 10.417,8C10.417,9.335 9.335,10.417 8,10.417C6.665,10.417 5.583,9.335 5.583,8Z" | ||
| android:fillColor="#091A3B" |
There was a problem hiding this comment.
I would keep that color as #000000
see the context: #6112 (comment)
There was a problem hiding this comment.
Lemme change that, but it has no effect as long as we apply the tint at runtime (which we should always do to follow the theme or we'll have problems in dark mode).
Btw I already had that discussion with my dear coderabbit 😄
|
3 participants
🎯 Goal
Continuing with the message content structural changes started in #6119 and #6124, this time for Giphy attachments. This PR updates the Giphy message design and integrates it with the component factory pattern.
🛠 Implementation details
🎨 UI Changes
🧪 Testing
Can be checked in the sample app by sending Giphy attachments.