Remove custom message actions from the Compose sample#6186
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
|
@coderabbitai review |
SDK Size Comparison 📏
|
WalkthroughThis pull request removes feature-related component factories and associated resources from the Android Compose sample application. Deleted components include MessageRemindersComponentFactory, DeleteMessageForMeComponentFactory, and MessageInfoComponentFactory. LocationComponentFactory is refactored to remove its delegation to MessageRemindersComponentFactory. Related drawable and string resources are also removed. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
stream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/location/LocationComponentFactory.kt (1)
55-60: Expand KDoc contract for this public factory.
LocationComponentFactoryis public; please document thread expectations (Compose/main thread) and key state behavior/fallbacks in the KDoc to match project API docs standards.As per coding guidelines, "Document public APIs with KDoc, including thread expectations and state notes".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/location/LocationComponentFactory.kt` around lines 55 - 60, The public class LocationComponentFactory lacks KDoc describing thread expectations and state behavior; update the KDoc for LocationComponentFactory (which implements ChatComponentFactory and accepts a nullable SharedLocationViewModelFactory) to state that its components are intended to be used on the main/Compose UI thread, describe how it handles null locationViewModelFactory (fallback behavior), and note any key state lifecycles or recomposition expectations for created composables; keep the comment concise and aligned with project API docs standards.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@stream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/location/LocationComponentFactory.kt`:
- Around line 55-60: The public class LocationComponentFactory lacks KDoc
describing thread expectations and state behavior; update the KDoc for
LocationComponentFactory (which implements ChatComponentFactory and accepts a
nullable SharedLocationViewModelFactory) to state that its components are
intended to be used on the main/Compose UI thread, describe how it handles null
locationViewModelFactory (fallback behavior), and note any key state lifecycles
or recomposition expectations for created composables; keep the comment concise
and aligned with project API docs standards.
ℹ️ Review info
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
stream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/feature/reminders/MessageRemindersComponentFactory.ktstream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/component/DeleteMessageForMeComponentFactory.ktstream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/component/MessageInfoComponentFactory.ktstream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/location/LocationComponentFactory.ktstream-chat-android-compose-sample/src/main/res/drawable/ic_bell_filled_24.xmlstream-chat-android-compose-sample/src/main/res/drawable/ic_bookmark_filled_24.xmlstream-chat-android-compose-sample/src/main/res/values/strings.xml
💤 Files with no reviewable changes (6)
- stream-chat-android-compose-sample/src/main/res/drawable/ic_bookmark_filled_24.xml
- stream-chat-android-compose-sample/src/main/res/values/strings.xml
- stream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/feature/reminders/MessageRemindersComponentFactory.kt
- stream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/component/MessageInfoComponentFactory.kt
- stream-chat-android-compose-sample/src/main/res/drawable/ic_bell_filled_24.xml
- stream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/component/DeleteMessageForMeComponentFactory.kt
a19c469 to
0399a10
Compare
|



Goal
We aligned to remove the custom message actions from the sample
Implementation
🎨 UI Changes
The UI didn't really change. It's just that the sample will show fewer actions than before
Testing
Check the sample to validate those actions aren't shown anymore
Summary by CodeRabbit
Release Notes