Skip to content

Fix excessive space between single-line messages#6315

Merged
gpunto merged 2 commits intov7from
fix/messages-spacing
Mar 31, 2026
Merged

Fix excessive space between single-line messages#6315
gpunto merged 2 commits intov7from
fix/messages-spacing

Conversation

@gpunto
Copy link
Copy Markdown
Contributor

@gpunto gpunto commented Mar 30, 2026

Goal

Single-line messages have excessive padding between them

Implementation

It happened because the swipe-to-reply icon had a minimum size (48dp) so it caused the whole item to grow vertically

🎨 UI Changes

Before After
Screenshot_20260330_161212 Screenshot_20260330_161142

Testing

Launch the app and check that the spacing vs messages is correct, both if the messages are small (single line) and in other cases

Summary by CodeRabbit

  • Refactor
    • Refined the sizing behavior of the reply icon in message swipe actions.

@gpunto gpunto added the pr:bug Bug fix label Mar 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@gpunto gpunto force-pushed the fix/messages-spacing branch from 7e2672e to 42a86c5 Compare March 30, 2026 14:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.25 MB 5.68 MB 0.43 MB 🟡
stream-chat-android-ui-components 10.60 MB 10.99 MB 0.39 MB 🟡
stream-chat-android-compose 12.81 MB 12.11 MB -0.70 MB 🚀

@sonarqubecloud
Copy link
Copy Markdown

@gpunto gpunto marked this pull request as ready for review March 31, 2026 07:25
@gpunto gpunto requested a review from a team as a code owner March 31, 2026 07:25
@gpunto gpunto enabled auto-merge (squash) March 31, 2026 07:25
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 31, 2026

Walkthrough

The pull request removes the minimumInteractiveComponentSize() modifier from a Box component in the SwipeToReplyIcon function. The icon container now applies only explicit size, shape clipping, and background modifiers, eliminating the automatic minimum interactive component sizing behavior.

Changes

Cohort / File(s) Summary
Modifier Removal
SwipeToReplyIcon.kt
Removed minimumInteractiveComponentSize() modifier import and its application to the icon container Box, leaving only explicit size(32.dp), clip(CircleShape), and background(...) modifiers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A swift little snip from the compose delight, 🐰
The icon sheds padding and grows small and tight,
No more minimum size rules the day,
Just thirty-two points in a circle's way! ✨
The reply swipes on, lean and light.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description includes Goal, Implementation, and UI Changes sections with before/after screenshots, but lacks detailed Testing instructions and is missing several required checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title directly addresses the main objective of the PR: fixing excessive space between single-line messages by removing the minimum interactive component size from the swipe-to-reply icon.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/messages-spacing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gpunto gpunto changed the title Fix excessive padding between single-line messages Fix excessive space between single-line messages Mar 31, 2026
@gpunto gpunto merged commit a04b6d6 into v7 Mar 31, 2026
17 checks passed
@gpunto gpunto deleted the fix/messages-spacing branch March 31, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants