Skip to content

Apply IME padding in create poll screen#6334

Merged
andremion merged 1 commit intov7from
create-poll-ime-padding
Apr 7, 2026
Merged

Apply IME padding in create poll screen#6334
andremion merged 1 commit intov7from
create-poll-ime-padding

Conversation

@gpunto
Copy link
Copy Markdown
Contributor

@gpunto gpunto commented Apr 3, 2026

Goal

The create poll screen is not fully scrollable when the keyboard is open

Implementation

We apply imePadding so that the content effectively resizes when the keyboard is open and can scroll. This also solves the problem occurring when adding an option that goes outside of the visible content portion -> after the changes, the column will auto scroll to show the focused input.

🎨 UI Changes

None

Testing

Open the create poll screen, open the keyboard, and verify that you can scroll to the bottom.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed poll creation screen layout to properly adjust when the keyboard appears, preventing content overlap and improving user interaction.

@gpunto gpunto added the pr:improvement Improvement label Apr 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.25 MB 5.86 MB 0.61 MB 🔴
stream-chat-android-ui-components 10.60 MB 11.15 MB 0.55 MB 🔴
stream-chat-android-compose 12.81 MB 12.40 MB -0.41 MB 🚀

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 3, 2026

@gpunto gpunto marked this pull request as ready for review April 7, 2026 07:40
@gpunto gpunto requested a review from a team as a code owner April 7, 2026 07:40
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 68d39614-f0d0-4c8a-b758-b19d0cffd892

📥 Commits

Reviewing files that changed from the base of the PR and between c7a5360 and 2883fd9.

📒 Files selected for processing (1)
  • stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/attachments/poll/CreatePollScreen.kt

Walkthrough

Updated the CreatePollScreen to add keyboard inset padding via imePadding() modifier and reorganized the Column's scroll behavior by moving verticalScroll() earlier in the modifier chain while simplifying the final modifier composition.

Changes

Cohort / File(s) Summary
CreatePollScreen Layout Updates
stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/attachments/poll/CreatePollScreen.kt
Enhanced Scaffold modifier with imePadding() for keyboard inset handling. Reorganized Column modifier chain by relocating verticalScroll() to an earlier position and removing duplicate scroll behavior from the modifier tail.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A poll screen so neat, now keyboards won't hide,
We scrolled through the modifiers, reorganized with pride!
Paddings and insets, arranged just right,
Layout flows smoothly—what a delightful sight! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: applying IME padding to the create poll screen, which directly matches the file modifications.
Description check ✅ Passed The PR description covers the required sections: Goal explains the problem, Implementation details the solution, and Testing provides verification steps. While UI Changes and some checklist items are minimal, the core content is complete and sufficient.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch create-poll-ime-padding

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@andremion andremion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@andremion andremion merged commit 9de79c4 into v7 Apr 7, 2026
17 checks passed
@andremion andremion deleted the create-poll-ime-padding branch April 7, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:improvement Improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants